build: add spotless, checkstyle, and enforcer plugin configuration#23
build: add spotless, checkstyle, and enforcer plugin configuration#23wombatu-kun wants to merge 1 commit into
Conversation
fd50c7c to
72001b5
Compare
|
Hi @fightBoxing, when you have a moment, could you take a look at this one? This PR only adds configuration and does not bind Spotless or Checkstyle to any build phase, so merging it cannot change It is intentionally the first link in a small, reviewable chain: #23 sets up the config, #24 applies the initial There is also a merge-order angle with #48: since that PR turns the root |
Summary
checkstyle.xmlported fromlance-spark..editorconfigfor cross-IDE consistency (UTF-8, LF, 4-space Java,2-space XML/YAML, tab Makefile,
max_line_length = 100).spotless-maven-plugin2.43.0 with google-java-format 1.19.2(GOOGLE style),
importOrder = org.apache.flink,,javax,java,#,removeUnusedImports, and the short Apache 2.0 license header.Invoked explicitly:
mvn spotless:check/mvn spotless:apply.maven-checkstyle-plugin3.3.1 withconfigLocation=checkstyle.xml,failsOnError=true,violationSeverity=warning. Invoked explicitly:mvn checkstyle:check.maven-enforcer-plugin3.4.1 withrequireMavenVersion 3.6.3andbanDuplicatePomDependencyVersions, bound to thevalidatephase.Spotless and Checkstyle are intentionally not bound to a build phase
in this PR. They will be wired into the
validatephase in the follow-upPR
chore: apply initial spotless formatting, which also runsmvn spotless:applyagainst the existing 31.javafiles. Splitting thework this way keeps the configuration PR small and reviewable, and the
formatting PR mechanical and trivially reviewable.